Skip to content

Fix for IE8 undefined setState in route#119

Closed
onyxrev wants to merge 1 commit intojupiterjs:masterfrom
onyxrev:v3.2.2-routepatch
Closed

Fix for IE8 undefined setState in route#119
onyxrev wants to merge 1 commit intojupiterjs:masterfrom
onyxrev:v3.2.2-routepatch

Conversation

@onyxrev
Copy link

@onyxrev onyxrev commented Mar 10, 2012

See http://forum.javascriptmvc.com/topic/route-issue-in-ie8 for details
FIx is just shuffling the onReady down a bit.

@justinbmeyer
Copy link
Member

Thanks! This is already fixed in CanJS. It will be fixed in 3.3.

@markalanevans
Copy link

So this won't be in future fixes 3.2.5+ etc? I just had this issue entire site was breaking on IE 7+. Just took this:
// onready
$(function() {
$.route.ready();
});

from the /jquery/dom/route/route.js class and move it to the very last line. All was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants