Fixed tap so that quick horizontal/vertical swipes did not cause tap events#142
Merged
daffl merged 1 commit intojupiterjs:masterfrom Oct 11, 2012
Merged
Conversation
daffl
added a commit
that referenced
this pull request
Oct 11, 2012
Fixed tap so that quick horizontal/vertical swipes did not cause tap events
Contributor
|
Thank you! I merged it, but we will probably make this tap event an official part of jQuery++ for the future (https://github.com/jupiterjs/jquerypp/blob/master/event/tap/tap.js). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed while working on a bug in MindTap on the iPad that the tap event would fire if a swipe happened that was close in either the X or Y direction, where it should be both X AND Y that need to be close together. Here's our proposed fix.