Don't hookup val() or text().#89
Merged
polgfred merged 1 commit intojupiterjs:masterfrom Nov 16, 2011
Merged
Conversation
The value passed to either of these must be HTML encoded, so it should not produce an element to hookup to. $(args[0]) causes problems when the value or text contains HTML (which should be encoded). See http://jsfiddle.net/mUxPq/
polgfred
added a commit
that referenced
this pull request
Nov 16, 2011
Don't hookup val() or text(). Neither of these operations will produce an element to hookup to. Fixes a bug where text() or val() incorrectly attempts to insert a DOMElement when the text is HTML-like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value passed to either of these must be HTML encoded, so it should not produce an element to hookup to. $(args[0]) causes problems when the value or text contains HTML (which should be encoded). See http://jsfiddle.net/mUxPq/