Test for demonstrating $.route not unbinding in Controller destruction#95
Closed
onyxrev wants to merge 1 commit intojupiterjs:masterfrom
onyxrev:master
Closed
Test for demonstrating $.route not unbinding in Controller destruction#95onyxrev wants to merge 1 commit intojupiterjs:masterfrom onyxrev:master
onyxrev wants to merge 1 commit intojupiterjs:masterfrom
onyxrev:master
Conversation
…und on Controller destruction.
Member
|
I fixed this in my branch. I'm going to merge it wednesday when I get back to the states. |
Author
|
Rad! I'd be really interested to see the diff when you do. |
Member
|
This pull changes almost every line so I can't pull w/o losing history. I think the line endings or maybe tabs v spaces are broken. However, I pushed my changes so this should work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a ghetto test to demonstrate $.route bindings not being properly unbound on Controller destruction.
This is my first test, so it's not the cleanest thing in the world. Couldn't get the other tests to run past the callbacks but it at least demonstrates the problem.
SHA: 1d9074e