-
Notifications
You must be signed in to change notification settings - Fork 14
Experimental datepicker example #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Sorry, I have hardly to no experience with webpack. |
Can you shed some light on how the |
Take a look in the Gruntfile: https://github.com/jquery/jquery-ui/blob/datepicker/Gruntfile.js#L476-L509 |
Afair we wanted to deliver a minimal (EN only) version while having some tool similar (or built-in) to download builder. Some Grunt tasks would be nice to I guess. From the Datepicker wiki:
|
None of that should be necessary with the globalize webpack plugin, since that deals with loading and compiling CLDR data. I tried to simply ignored those dependencies using
That produces a build, but it then fails at runtime due to missing CLDR data, "E_MISSING_CLDR: Missing required CLDR content @rxaviers any idea why this isn't working? |
I did another PR, #4, where I more closely copy the webpack reference config from https://github.com/globalizejs/globalize/blob/master/examples/app-npm-webpack/webpack-config.js |
Basically the issues are:
|
This seems like it would be much more useful to change in the plugin. Its really hard to tell how difficult that really is, but at a glance it doesn't seem so bad...
Here I wonder why we even have the
As far as I remember, we wanted to remove that option from spinner... |
Yup, that's probably just out-of-date information. We are definitely dropping the locale option from spinner in favor of providing custom parser and formatter options. However, calendar/datepicker will have a lot of options to set based on locale. We probably need to have a team discussion about how to handle this. |
This is adding the datepicker rewrite, in its current state, to the demo, using the globalize-webpack-plugin. Currently this doesn't work, since datepicker.js and calendar.js specify two dependencies that can't be resolved,
globalize/date
andglobalize-locales
. To reproduce locally, check out this branch, runnpm install
andnpm start
:I looked at the mappings for these in jQuery UI's
bootstrap.js
, but couldn't figure out how these would/should work in the context of a webpack app.Ping @rxaviers @fnagel @scottgonzalez - any input on this?