Skip to content

File name fix and character encoding fix#17

Closed
mochetts wants to merge 3 commits intokayalshri:masterfrom
mochetts:master
Closed

File name fix and character encoding fix#17
mochetts wants to merge 3 commits intokayalshri:masterfrom
mochetts:master

Conversation

@mochetts
Copy link

@mochetts mochetts commented Dec 30, 2014

  1. File name was not being set properly (always using "download")
  2. Sometimes it's needed to use an octet-stream instead of a base64 string in order to avoid encoding issues with characters like "ñ"

- 1) File name was not being set properly (always using "download")
- 2) Sometimes it's neede to use an octet-stream instead of a base64 string in order to avoud encoding issues with characters like "ñ"
@nevermind89x
Copy link

is this gonna be merged?

@calesherry
Copy link

Agreed this should be merged

@jackmatt2
Copy link

Need this also.

@hhurz
Copy link

hhurz commented Jan 10, 2017

@jackmatt2: Have you tried this fork of the plugin? There is a filename option and many other fixes.

@jackmatt2
Copy link

jackmatt2 commented Jan 10, 2017 via email

@mochetts mochetts closed this May 28, 2021
@mochetts
Copy link
Author

Closed PR due to inactivity. Don't want to see it on my dashboard anymore 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants