Added Dockerfile and docker-compose.yml to run the project on Docker environment#23
Open
kciejek wants to merge 1 commit intokkuchta:masterfrom
Open
Added Dockerfile and docker-compose.yml to run the project on Docker environment#23kciejek wants to merge 1 commit intokkuchta:masterfrom
kciejek wants to merge 1 commit intokkuchta:masterfrom
Conversation
ohld
approved these changes
May 17, 2019
gautamkrishnar
suggested changes
May 17, 2019
| FROM ruby:latest | ||
|
|
||
| COPY . . | ||
| RUN apt-get update && apt-get install -y redis-server && gem install bundler -v '2.0.1' && bundle update --bundler |
There was a problem hiding this comment.
@kciejek
Can we move this to separate layer. Copying entire app files before installing dependencies is not a good approach.
Please see the best practices: https://medium.com/the-code-review/docker-copy-dockerfile-best-practices-503704bee69f
There was a problem hiding this comment.
Ideally this should be the Dockerfile:
FROM ruby:latest
WORKDIR /app
COPY Gemfile Gemfile.lock ./
RUN apt-get update && apt-get install -y redis-server && gem install bundler -v '2.0.1' && bundle update --bundler
COPY . .
CMD eval 'redis-server &' && bundle install && bundle exec puma|
There's already a similar PR ref #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run with: docker-compose up