Skip to content

Conversation

@jhen0409
Copy link
Contributor

@jhen0409 jhen0409 commented Jul 4, 2018

React XP has another supported types (web, macos, windows). I also need that for RN web / RN dom.

It also required to update react-native-css-media-query-processor.

Thank you @kristerkari!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 85

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.099%

Totals Coverage Status
Change from base Build 84: 0.0%
Covered Lines: 67
Relevant Lines: 67

💛 - Coveralls

@kristerkari
Copy link
Owner

Thanks a lot @jhen0409!

Adding those types definitely makes sense! I haven't used React XP, so I did not even think about the other platform options.

So, does React Native DOM return dom when you call Platform.OS?

Also, couple of things that I want to add now are unit tests and documentation for this feature.

@kristerkari
Copy link
Owner

Oh, and one thing. Doing @media web and (max-width: 200px) would probably not work with React Native for Web as the normal media queries don't support that syntax.

I don't know what the thing is with React Native DOM, would it be using just the React Native code to handle media queries?

@kristerkari
Copy link
Owner

I just noticed that it's React XP that has the web platform type defined, not React Native for web, so ignore my previous comment.

@jhen0409
Copy link
Contributor Author

jhen0409 commented Jul 4, 2018

So, does React Native DOM return dom when you call Platform.OS?

Yes. (Platform.dom.js)

Oh, and one thing. Doing @media web and (max-width: 200px) would probably not work with React Native for Web as the normal media queries don't support that syntax.

It should work because React Native Web made the same style sheet manager.

@kristerkari kristerkari merged commit 34e6ce9 into kristerkari:master Jul 4, 2018
@kristerkari
Copy link
Owner

Great, I'll add some documentation and tests for these changes.

@jhen0409 jhen0409 deleted the more-platforms branch July 4, 2018 09:50
kristerkari added a commit to kristerkari/react-native-css-media-query-processor that referenced this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants