Skip to content

Filter __mediaQueries for output #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Conversation

jhen0409
Copy link
Contributor

@jhen0409 jhen0409 commented Jul 4, 2018

Currently I can't just use the result of process(styles, {}) for StyleSheet.create, I got the following error:

screen shot 2018-07-04 at 8 56 16 pm

I need to remove that like the tests, but this is not very convenient. I think just filter that will be better, I've also updated the tests, it shouldn't have any effects.

@coveralls
Copy link

coveralls commented Jul 4, 2018

Pull Request Test Coverage Report for Build 74

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 98.649%

Totals Coverage Status
Change from base Build 71: 0.04%
Covered Lines: 82
Relevant Lines: 83

💛 - Coveralls

@kristerkari
Copy link
Owner

Thanks again!

I removed that because I have moved the logic to react-native-dynamic-style-processor and wanted to avoid duplicate work between that library and this one.

But as you can also directly use this library, it actually makes sense to remove the __mediaQueries key from the object in this library.

@kristerkari kristerkari merged commit 8a714d5 into kristerkari:master Jul 4, 2018
@kristerkari
Copy link
Owner

Released in v0.21.1

@jhen0409 jhen0409 deleted the patch-1 branch July 5, 2018 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants