@extend ing the same thing multiple times is broken

[leafo]

Input:

#something {
    color: red;
}

.x {
    @extend #something;
}

.y {
    @extend #something;
}

Expect:

#something, .x, .y {
  color: red; }

Actual:

#something, .x {
  color: red; }

[nessy]

I made a quick fix for this problem and thought I should post it here for others to use temporarily until this is fixed.

The changes are all in the function matchExtendsSingle and contain 2 added variables
and 3 small code changes.

protected function matchExtendsSingle($single, &$out_origin, &$out_rem) {
    $counts = array();
    foreach ($single as $part) {
        if (!is_string($part)) return false; // hmm

        if (isset($this->extendsMap[$part])) {
            foreach ($this->extendsMap[$part] as $idx) {

                $counts[$idx] =
                    isset($counts[$idx]) ? $counts[$idx] + 1 : 1;
            }
        }
    }

    // ADD     these 2 variables are new
    $out_origin  = array();
    $found       = false;

    foreach ($counts as $idx => $count) {
        list($target, $origin) = $this->extends[$idx];

        // check count
        if ($count != count($target)) continue;
        // check if target is subset of single
        if (array_diff(array_intersect($single, $target), $target)) continue;

        // CHANGE     instead of setting $out_origin as $origin we merge them;
        $out_origin = array_merge($out_origin,$origin);
        $out_rem = array_diff($single, $target);

        // CHANGE     instead of returning true we set $found to true
        $found = true;
    }

    // CHANGE      instead of returning false we return the $found status
    return $found;
}

I hope this will help someone.

[psrpinto]

I'm having the same problem. @nessy Any chance you can create a PR with your solution?

[leafo]

Fix is merged