ifTruthy() commit breaks things

[jamesshannon]

Hi All..

I just swapped in the most recent commit and started getting an error. I've tracked it down to 318b54 . If I replace the code with the previous commit, everything works fine.

This is being run on Foundation, and I'm getting the below error.

I'm not sure how to track this down to the line of scss that's causing it, but I can work through it if you have suggestions / need more info.

Fatal error: Maximum function nesting level of '100' reached, aborting! in /Users/jshannon/Documents/Work/Projects/C5 Theme/Repo/packages/lerteco_foundation/libraries/vendor/scss.inc.php on line 1355
Call Stack
#   Time    Memory  Function    Location
1   0.0007  633320  {main}( )   ../index.php:0
2   0.0012  736560  require( '/Library/WebServer/WebSites/concrete5source/c5602/concrete/dispatcher.php' )  ../index.php:2
3   0.0937  17577048    require( '/Library/WebServer/WebSites/concrete5source/c5602/concrete/startup/tools.php' )   ../dispatcher.php:122
4   0.0939  17608736    include( '/Library/WebServer/WebSites/concrete5source/c5602/concrete/tools/css.php' )   ../tools.php:29
5   0.0961  17745464    LertecoFoundationPageTheme->parseStyleSheet( )  ../css.php:25
6   0.0967  17755944    scssc->compile( )   ../foundation_page_theme.php:63
7   0.4282  19200664    scssc->compileRoot( )   ../scss.inc.php:87
8   0.4283  19202968    scssc->compileChildren( )   ../scss.inc.php:280
9   0.5380  19767896    scssc->compileChild( )  ../scss.inc.php:443
10  0.5380  19768784    scssc->compileImport( ) ../scss.inc.php:516
11  0.5382  19768984    scssc->importFile( )    ../scss.inc.php:485
12  0.5568  19819864    scssc->compileChildren( )   ../scss.inc.php:1450
13  0.6718  20240832    scssc->compileChild( )  ../scss.inc.php:443
14  0.6721  20275968    scssc->compileImport( ) ../scss.inc.php:516
15  3.7668  33399496    scssc->compileImport( ) ../scss.inc.php:498
16  3.7670  33399720    scssc->importFile( )    ../scss.inc.php:485
17  3.9667  34184488    scssc->compileChildren( )   ../scss.inc.php:1450
18  3.9688  34197064    scssc->compileChild( )  ../scss.inc.php:443
19  3.9688  34197064    scssc->compileChildren( )   ../scss.inc.php:580
20  3.9688  34197368    scssc->compileChild( )  ../scss.inc.php:443
21  3.9688  34197368    scssc->compileMedia( )  ../scss.inc.php:529
22  3.9689  34200152    scssc->compileChildren( )   ../scss.inc.php:314
23  3.9689  34200544    scssc->compileChild( )  ../scss.inc.php:443
24  3.9689  34200544    scssc->compileBlock( )  ../scss.inc.php:532
25  3.9690  34204728    scssc->compileChildren( )   ../scss.inc.php:351
26  3.9690  34205472    scssc->compileChild( )  ../scss.inc.php:443
27  3.9788  34282312    scssc->compileChild( )  ../scss.inc.php:674
28  3.9862  34301480    scssc->compileChild( )  ../scss.inc.php:674
29  3.9863  34301480    scssc->compileChildren( )   ../scss.inc.php:586
30  3.9865  34301920    scssc->compileChild( )  ../scss.inc.php:443
31  3.9865  34301920    scssc->compileBlock( )  ../scss.inc.php:532
32  3.9866  34308280    scssc->compileChildren( )   ../scss.inc.php:351
33  3.9866  34308584    scssc->compileChild( )  ../scss.inc.php:443
34  3.9868  34311088    scssc->compileChild( )  ../scss.inc.php:674
35  3.9868  34311136    scssc->reduce( )    ../scss.inc.php:579
36  3.9868  34311136    scssc->reduce( )    ../scss.inc.php:852
37  3.9868  34313104    scssc->reduce( )    ../scss.inc.php:861
38  3.9868  34313152    scssc->reduce( )    ../scss.inc.php:852
39  3.9868  34315120    scssc->reduce( )    ../scss.inc.php:861
40  3.9868  34315168    scssc->reduce( )    ../scss.inc.php:852
and another 60 of these...

[leafo]

a limit of 100 seems pretty low:

http://stackoverflow.com/questions/4293775/increasing-nesting-functions-calls-limit

[jamesshannon]

Well, that's fair... I updated to 5000, though, and got the same thing:

Fatal error: Maximum function nesting level of '5000' reached, aborting! in /Users/jshannon/Documents/Work/Projects/C5 Theme/Repo/packages/lerteco_foundation/libraries/vendor/scss.inc.php on line 1356

When I updated to 10000 I ran out of memory:

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 523800 bytes)

Same back-and-forth with the two lines.

[leafo]

hmm, okay this sounds like infinite recursion. Is this on a regular checkout of foundation? I want to try to reproduce on my machine.

[jamesshannon]

Not really. I've made a few changes, and it's being run through a CMS.

I seem to be finding a lot of Foundation-related issues, so I should probably set up a regular foundation scssphp CLI test install. I can do that later and report back if I get the same error and, if not, I can try to isolate my changes.

Speaking of which... I thought I was pretty handy with PHP until I came across your package. :) I've caught a number of bugs, but never have much luck tracking them down. If I had a guide that explained how SCSSPHP worked, or even some php docs on the functions, I might be able to be more help when I find something...

[leafo]

Sorry about the lack of code documentation. It deserves some because it's a pretty complicated project.

I don't know if this helps, buy my other project lessphp uses the same parsing/compiling model and the code is more commented.

Here are the relevant comments:

https://github.com/leafo/lessphp/blob/master/lessc.inc.php#L15
https://github.com/leafo/lessphp/blob/master/lessc.inc.php#L2139

https://github.com/leafo/lessphp/blob/master/lessc.inc.php#L163
https://github.com/leafo/lessphp/blob/master/lessc.inc.php#L718

There are a handful of differences though, so your mileage may vary. scssphp is more complicated than lessphp just because it has some more advanced featured.

[jamesshannon]

You don't have to apologize; we're developers, not documenters. I was simply trying to make an excuse for why I'm reporting so many bugs, but not making any contributions / pull requests. :)

I just created a little CLI-based foundation / scss test suite with most recent repo checkouts of each. I am, in fact, getting the same infinite recursion error. This time (with current source), it's:

PHP Fatal error:  Maximum function nesting level of '1000' reached, aborting! in /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php on line 1359
PHP Stack trace:
PHP   1. {main}() /Users/jshannon/Documents/Work/Projects/SCSSPHP/tester.php:0
PHP   2. scssc->compile() /Users/jshannon/Documents/Work/Projects/SCSSPHP/tester.php:12
PHP   3. scssc->compileRoot() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:87
PHP   4. scssc->compileChildren() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:278
PHP   5. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:441
PHP   6. scssc->compileImport() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:514
PHP   7. scssc->compileImport() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:496
PHP   8. scssc->importFile() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:483
PHP   9. scssc->compileChildren() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:1454
PHP  10. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:441
PHP  11. scssc->compileChildren() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:584
PHP  12. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:441
PHP  13. scssc->compileMedia() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:527
PHP  14. scssc->compileChildren() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:312
PHP  15. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:441
PHP  16. scssc->compileBlock() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:530
PHP  17. scssc->compileChildren() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:349
PHP  18. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:441
PHP  19. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:678
PHP  20. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:678
PHP  21. scssc->compileChildren() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:590
PHP  22. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:441
PHP  23. scssc->compileBlock() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:530
PHP  24. scssc->compileChildren() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:349
PHP  25. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:441
PHP  26. scssc->compileChild() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:678
PHP  27. scssc->reduce() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:583
PHP  28. scssc->reduce() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:856
PHP  29. scssc->reduce() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:865
PHP  30. scssc->reduce() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:856
PHP  31. scssc->reduce() /Users/jshannon/Documents/Work/Projects/SCSSPHP/scssphp/scss.inc.php:865
#30 and #31 repeated ...

I'll check out the less docs now.

[robocoder]

Reproduceable test cases are the next best thing to a PR.

[robocoder]

@jamesshannon is this closeable?

[jamesshannon]

Yes. Looks good. Thanks.