Null not being treated as false for if statements#161
Closed
wonderslug wants to merge 3 commits intoleafo:masterfrom
Closed
Null not being treated as false for if statements#161wonderslug wants to merge 3 commits intoleafo:masterfrom
wonderslug wants to merge 3 commits intoleafo:masterfrom
Conversation
Collaborator
|
IIRC there's an isTruthy() function. Maybe we can leverage that... |
Author
|
Good call. isTruthy is doing the same. Moved to that. |
Collaborator
|
Merged and squashed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howdy,
And into this issue trying to use Bourbon with scssphp. Scssphp is not recognizing the null keyword passed in to the if statement as a false. This is handled correctly with the ruby sass implementation. I added a small fix on the lib_if to check for the null case as well as the false case. I also added as small test to show the issue.