Add Ability for Leafo\ScssPhp\Server to display SASS errors via a psuedo-element#247
Closed
khamer wants to merge 1 commit intoleafo:masterfrom
Closed
Add Ability for Leafo\ScssPhp\Server to display SASS errors via a psuedo-element#247khamer wants to merge 1 commit intoleafo:masterfrom
khamer wants to merge 1 commit intoleafo:masterfrom
Conversation
* enables displaying errors as a psuedo element via CSS
Collaborator
|
Thanks! Merged into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add a method
->showErrorsAsCSS()toLeafo\ScssPhp\Serverthat changes how exceptions are handled during SASS compilation. Instead of sending a 500 with plain text, instead valid CSS is returned that creates a psuedo-element in the page containing the error message.This makes errors in the SASS visible to any HTML page including the compiled CSS, rather than rendering the page as unstyled.