minor fixes and optimizations#608
Closed
brainfoolong wants to merge 4 commits intoleafo:masterfrom
brainfoolong:master
Closed
minor fixes and optimizations#608brainfoolong wants to merge 4 commits intoleafo:masterfrom brainfoolong:master
brainfoolong wants to merge 4 commits intoleafo:masterfrom
brainfoolong:master
Conversation
Contributor
|
Checked this PR today, it's safe and ready to be pulled |
|
Do you have a branch with all your changes applied? |
Contributor
|
Yes i'm putting everything all together here https://github.com/Cerdic/scssphp/tree/maint/leafo/master but this is a work in progress, I'm still working on the #627 integration wich is at the moment coming with bugs |
Collaborator
|
I cherry-picked the commits from this PR with the exception of 4cc12d6. Currently, we use explicit |
robocoder
reviewed
Apr 24, 2019
| switch ($value[0]) { | ||
| case Type::T_EXPRESSION: | ||
| if ($value[1] === '/') { | ||
| return $this->shouldEval($value[2], $value[3]); |
Collaborator
There was a problem hiding this comment.
This isn't just a code smell. It looks like a bug.
robocoder
added a commit
that referenced
this pull request
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, just give you a little push in code readability and optimization. Also fixed a php error because of undefined variable.