Pr/leafo/627 : Add interpolation support selector#643
Merged
robocoder merged 4 commits intoleafo:masterfrom Apr 24, 2019
Cerdic:PR/leafo/627
Merged
Pr/leafo/627 : Add interpolation support selector#643robocoder merged 4 commits intoleafo:masterfrom Cerdic:PR/leafo/627
robocoder merged 4 commits intoleafo:masterfrom
Cerdic:PR/leafo/627
Conversation
This was referenced Apr 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fully reworked the proposal for PR #627 as it had no test case and it appears that the patch was causing
@at-rootdirective to fail in some already existing tests&{#}selector without and with at-root parentTests are OK and PSR2 compliant.
I'm sorry i was not able to keep the credits to @kingyond as I really had do break the full patch in parts to understand how it was (not fully) working before being able to build this new patch, but the original commit really helped me!