Skip to content

Unicode support in class/id name #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robocoder merged 2 commits into from
Jun 4, 2019
Merged

Unicode support in class/id name #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8238e
Unit test for supporting unicode high range chars in selector name (h…
Cerdic Jun 3, 2019
65a7995
Fix https://github.com/leafo/scssphp/issues/531 :
Cerdic Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2477,7 +2477,7 @@ protected function keyword(&$word, $eatWhitespace = null)
{
if ($this->match(
$this->utf8
? '(([\pL\w_\-\*!"\']|[\\\\].)([\pL\w\-_"\']|[\\\\].)*)'
? '(([\pL\w\x{00A0}-\x{10FFFF}_\-\*!"\']|[\\\\].)([\pL\w\x{00A0}-\x{10FFFF}\-_"\']|[\\\\].)*)'
: '(([\w_\-\*!"\']|[\\\\].)([\w\-_"\']|[\\\\].)*)',
$m,
$eatWhitespace
Expand Down
10 changes: 10 additions & 0 deletions tests/inputs/selectors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,3 +287,13 @@ ul, ol {
display: block;
}
}

// unicode
.👤 {
display: inline-block;
}

.❮ {
display:inline;
content:'↦';
}
7 changes: 7 additions & 0 deletions tests/outputs/selectors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,3 +370,10 @@ span a, p a, div a {

ul ul, ul ol, ol ul, ol ol {
display: block; }

.👤 {
display: inline-block; }

.❮ {
display: inline;
content: '↦'; }
7 changes: 7 additions & 0 deletions tests/outputs_numbered/selectors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,3 +407,10 @@ span a, p a, div a {

ul ul, ul ol, ol ul, ol ol {
display: block; }
/* line 292, inputs/selectors.scss */
.👤 {
display: inline-block; }
/* line 296, inputs/selectors.scss */
.❮ {
display: inline;
content: '↦'; }