Skip to content

Interpolation in comments#702

Merged
robocoder merged 6 commits intoleafo:masterfrom
Cerdic:Issue/leafo/565
Jun 4, 2019
Merged

Interpolation in comments#702
robocoder merged 6 commits intoleafo:masterfrom
Cerdic:Issue/leafo/565

Conversation

@Cerdic
Copy link
Contributor

@Cerdic Cerdic commented Jun 3, 2019

Fix #565

@Cerdic
Copy link
Contributor Author

Cerdic commented Jun 4, 2019

It suddenly hits me in the shower that there was an infinite loop with a single #{ sequence in the comments, so fixing it with additional test case - and also saw there was a forgotten var_dump in the PR, which is really bad :p

@Cerdic
Copy link
Contributor Author

Cerdic commented Jun 4, 2019

And added a fix for #479 in the same PR as its still on comment topic and would have had some merge conflict in a separate PR.
I'm done with this PR for real now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interpolation should work in block comments.

2 participants