fix !default bug#86
Merged
leafo merged 4 commits intoleafo:masterfrom May 17, 2013
robocoder:default-bug
Merged
Conversation
|
@jamesshannon you should use this: $defaultVar = is_array($nestedValue) && $nestedValue[0] == "list" && $this->stripDefault($value[2][count($value[2]) - 1]);Your version does not work in this situation. $sansFontFamily: "Helvetica Neue", Helvetica, Arial, sans-serif !default;Then please resubmit and I hope that @leafo merges this :) |
Contributor
|
@robocoder I think @albyrock87 's message was for you. Thoughts? |
Collaborator
Author
|
I'll take a look but @leafo may be too busy to review PRs. |
|
Thankyou @robocoder , let's hope that @leafo merges this soon. |
Owner
|
I made a minor clean up change. I'm sorry for taking so long to accept the patch! @robocoder I gave you commit access to this repository, thanks for all the help you've given so far. Feel free to merge in things you think are good. I'll of course still be around, I just don't want patches to sit around forever because I can't get to them. |
stilliard
pushed a commit
to WildfireInternet/scssphp
that referenced
this pull request
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need feedback.