Skip to content

fix !default bug#86

Merged
leafo merged 4 commits intoleafo:masterfrom
robocoder:default-bug
May 17, 2013
Merged

fix !default bug#86
leafo merged 4 commits intoleafo:masterfrom
robocoder:default-bug

Conversation

@robocoder
Copy link
Collaborator

Need feedback.

@albyrock87
Copy link

@jamesshannon you should use this:

$defaultVar = is_array($nestedValue) && $nestedValue[0] == "list" && $this->stripDefault($value[2][count($value[2]) - 1]);

Your version does not work in this situation.

$sansFontFamily:        "Helvetica Neue", Helvetica, Arial, sans-serif !default;

Then please resubmit and I hope that @leafo merges this :)

@jamesshannon
Copy link
Contributor

@robocoder I think @albyrock87 's message was for you. Thoughts?

@robocoder
Copy link
Collaborator Author

I'll take a look but @leafo may be too busy to review PRs.

@albyrock87
Copy link

Thankyou @robocoder , let's hope that @leafo merges this soon.

leafo added a commit that referenced this pull request May 17, 2013
@leafo leafo merged commit 0b57a52 into leafo:master May 17, 2013
leafo added a commit that referenced this pull request May 17, 2013
@leafo
Copy link
Owner

leafo commented May 17, 2013

I made a minor clean up change.

I'm sorry for taking so long to accept the patch! @robocoder I gave you commit access to this repository, thanks for all the help you've given so far. Feel free to merge in things you think are good. I'll of course still be around, I just don't want patches to sit around forever because I can't get to them.

@robocoder robocoder deleted the default-bug branch May 17, 2013 10:41
stilliard pushed a commit to WildfireInternet/scssphp that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants