Mixin @content with embedded mixin test cases#87
Merged
robocoder merged 1 commit intoleafo:masterfrom May 17, 2013
jamesshannon:content-mixins
Merged
Mixin @content with embedded mixin test cases#87robocoder merged 1 commit intoleafo:masterfrom jamesshannon:content-mixins
robocoder merged 1 commit intoleafo:masterfrom
jamesshannon:content-mixins
Conversation
|
Please fix this very soon! |
Regaddi
pushed a commit
to Regaddi/scssphp
that referenced
this pull request
Apr 24, 2013
stilliard
pushed a commit
to WildfireInternet/scssphp
that referenced
this pull request
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@include with arguments inside of a @content block causes issues
I added a handful of test-cases with increasing complexity to show where things break. I initially thought that it was a problem with parent @content mixins that also have arguments, but it doesn't seem to be the case.
Embedded mixin arguments aren't passed. This:
becomes
coolis included just as in another test case, which works fine.The problem popped up in the Inuit framework with the grid system being mixed in within a @media query mixin. I've given up on Foundation, so I'm sure I'll have a whole new group of issues... :)
For a background of @content mixins, see http://sass-lang.com/docs/yardoc/file.SASS_REFERENCE.html#mixin-content