Remove upper bounds of dependencies#113
Merged
lervag merged 1 commit intolervag:masterfrom Mar 30, 2025
Merged
Conversation
Owner
|
Sorry for the slow reply!
No problem, I like keeping it simple!
I think you are right that there is no need to set an upper bound here. So I'll accept this PR as it stands. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not discuss this PR beforehand because it's simple and thought it's easier to just do a PR and discuss here instead of creating a separate issue beforehand.
I'm trying to add
apyankias a https://github.com/NixOS/nixpkgs package. They package the latest dependencies only to lower the maintenance burden. Upper bounds on dependencies break the package build because nixpkgs gets newer packages frequently.The project builds and tests pass with this patch with the current unstable nixpkgs dependency versions.
Feel free to close if you don't like dependencies without upper bounds. Otherwise, let me know if you'd like me to do any modifications.