Skip to content

Remove upper bounds of dependencies#113

Merged
lervag merged 1 commit intolervag:masterfrom
icyrockcom:master
Mar 30, 2025
Merged

Remove upper bounds of dependencies#113
lervag merged 1 commit intolervag:masterfrom
icyrockcom:master

Conversation

@icyrockcom
Copy link
Copy Markdown

I did not discuss this PR beforehand because it's simple and thought it's easier to just do a PR and discuss here instead of creating a separate issue beforehand.

I'm trying to add apyanki as a https://github.com/NixOS/nixpkgs package. They package the latest dependencies only to lower the maintenance burden. Upper bounds on dependencies break the package build because nixpkgs gets newer packages frequently.

The project builds and tests pass with this patch with the current unstable nixpkgs dependency versions.

Feel free to close if you don't like dependencies without upper bounds. Otherwise, let me know if you'd like me to do any modifications.

@lervag
Copy link
Copy Markdown
Owner

lervag commented Mar 30, 2025

Sorry for the slow reply!

I did not discuss this PR beforehand because it's simple and thought it's easier to just do a PR and discuss here instead of creating a separate issue beforehand.

No problem, I like keeping it simple!

I'm trying to add apyanki as a https://github.com/NixOS/nixpkgs package. They package the latest dependencies only to lower the maintenance burden. Upper bounds on dependencies break the package build because nixpkgs gets newer packages frequently.

The project builds and tests pass with this patch with the current unstable nixpkgs dependency versions.

I think you are right that there is no need to set an upper bound here. So I'll accept this PR as it stands. Thanks for contributing!

@lervag lervag merged commit ea1174f into lervag:master Mar 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants