Enable completion for glossary entries defined with `newabbreviation` from glossaries-extra

[PatrickJosh]

Is your feature request related to a problem? Please describe it.
I use the glossaries-extra package to manage my acronyms. It defines the new command newabbreviation, which enables the usage of multiple acronym categories. The main purpose of the categories is to allow for different styling of acronyms, i.e. that some acronyms use the short form in different places than others. Internally, glossaries-extra redefines the newacronym command from glossaries to use newabbreviation as well; it assigns the acronyms defined with newacronym the default category acronym.

When writing my document, I noticed that I did not have any autocompletion for my glossary entries defined with newabbreviation, but that I could auto-complete them when using newacronym to define them. Hence, I figured that completion for newabbreviation does not exist yet.

Describe the solution you'd like
Just auto-complete entries defined with newabbreviation like the ones defined with newacronym.

Describe alternatives you've considered
Nothing, actually. I suppose it is quite straightforward.

Additional context
Thanks very much for developing and maintaining vimtex! :)

[lervag]

Sorry for the slow response!

Now, there should be auto-completion for newabbreviations as well. The relevant code is here:

vimtex/autoload/vimtex/complete.vim

Lines 530 to 536 in 82d2305

	\ 'key' : {
	\ 'newglossaryentry' : ' [gls]',
	\ 'longnewglossaryentry' : ' [gls]',
	\ 'newacronym' : ' [acr]',
	\ 'newabbreviation' : ' [abbr]',
	\ 'glsxtrnewsymbol' : ' [symbol]',
	\ },

In fact, it should give exactly the same candidates. And if \newacronym works, then it is quite surprising that \newabbreviation does not work, since they are implemented exactly the same way. 🤔

---

Thanks very much for developing and maintaining vimtex! :)

Thanks! I'm not as active as I would have liked, but I try to keep up a minimum of maintenance at least!

[PatrickJosh]

No worries! Thanks for responding! 😄

I've just tried it again, and unfortunately, it does not work still. I've had a look at the code and might it be this snippet that is the culprit?

vimtex/autoload/vimtex/syntax/p/glossaries.vim

Lines 14 to 16 in 82d2305

	" \newacronym -> opt -> arg1 -> arg2 -> arg3
	syntax match texCmdNewAcr "\\newacronym\>"
	\ nextgroup=texNewAcrOpt,texNewAcrArgLabel skipwhite skipnl

I'm not good at reading vimscript, so please correct me if I'm wrong, but to me, it seems like this is responsible for parsing the newacronym definitions. However, a similar thing for newabbreviation is missing.

[lervag]

No worries! Thanks for responding! 😄

I've just tried it again, and unfortunately, it does not work still. I've had a look at the code and might it be this snippet that is the culprit?

Would you be able to make a minimal example and explain the steps required to reproduce the issue?

vimtex/autoload/vimtex/syntax/p/glossaries.vim

Lines 14 to 16 in 82d2305
" \newacronym -> opt -> arg1 -> arg2 -> arg3
syntax match texCmdNewAcr "\newacronym>"
\ nextgroup=texNewAcrOpt,texNewAcrArgLabel skipwhite skipnl

I'm not good at reading vimscript, so please correct me if I'm wrong, but to me, it seems like this is responsible for parsing the newacronym definitions. However, a similar thing for newabbreviation is missing.

Oh, no, that's not relevant here. That's the syntax highlighting of the \newacronym commands, and it is not used for completion at all.