Skip to content

Compiler vlty: respect Vim variable fileencoding#1839

Closed
matze-dd wants to merge 3 commits intolervag:masterfrom
matze-dd:master
Closed

Compiler vlty: respect Vim variable fileencoding#1839
matze-dd wants to merge 3 commits intolervag:masterfrom
matze-dd:master

Conversation

@matze-dd
Copy link
Copy Markdown
Contributor

This relates to issue #1829.

  • vlty.vim: According to the doc, fileencoding may be empty. Then encoding is used.
  • options.vim: added default for encoding
  • vimtex.txt:
    • As in the previous PR, I'm undecided about the order of the options. Please feel free to change that ;-)
    • I have wrapped some lines that were longer than 80 characters.

lervag added a commit that referenced this pull request Oct 24, 2020
@lervag
Copy link
Copy Markdown
Owner

lervag commented Oct 24, 2020

Thanks! I think this is good enough for an immediate merge (I just had to fix a minor typo).

As in the previous PR, I'm undecided about the order of the options. Please feel free to change that ;-)

The option description comes in a consistent order compared to the default dict, which is nice. In many cases, the order is irrelevant, and I often try to use e.g. alphabetic order. However, in some cases it feels right to put the important things on top. This does result in some things being in semi random order. I don't think it's a problem, but if anyone does I'm glad to discuss it.

I have wrapped some lines that were longer than 80 characters.

I've often tried to keep things wrapped to 79 or 80 characters on the visual columns. E.g., in lines that have a lot of concealed characters, I tend to allow more than 80 characters. But then I guess there's some/many who don't have conceals enabled at all, so perhaps that's a bad idea.

@lervag lervag closed this Oct 24, 2020
@matze-dd
Copy link
Copy Markdown
Contributor Author

Thanks for merging!

I've often tried to keep things wrapped to 79 or 80 characters on the visual columns. E.g., in lines that have a lot of concealed characters, I tend to allow more than 80 characters. But then I guess there's some/many who don't have conceals enabled at all, so perhaps that's a bad idea.

Ah, I see. For instance, there was a line with 81 characters:

  This option is used to configure the `vlty` grammar checker. It is a dictionary 

With my simple configuration, in :help, the backticks around vlty are displayed, so that the line is wrapped in an 80-column terminal.

@lervag
Copy link
Copy Markdown
Owner

lervag commented Oct 26, 2020

Yes, that makes sense. I'll revert my silly practice of considering the visual columns in future updates to the docs. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants