Compiler vlty: ensure compatibility with vim-dispatch#1856
Closed
matze-dd wants to merge 2 commits intolervag:masterfrom
matze-dd:master
Closed
Compiler vlty: ensure compatibility with vim-dispatch#1856matze-dd wants to merge 2 commits intolervag:masterfrom matze-dd:master
matze-dd wants to merge 2 commits intolervag:masterfrom
matze-dd:master
Conversation
Contributor
Author
|
Updated after discussion in #1854. |
lervag
added a commit
that referenced
this pull request
Nov 20, 2020
Owner
|
Thanks, I've merged this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to issue #1854. An issue from vim-dispatch loosely relates to ours.
The proposed solution should be less dubious than the quick fix from #1854. The latter just said twice: "Please ignore all other lines." No clue, why this works as intended.
In the new
errorformat, all message lines from YaLafi are explicitly consumed.The part
%+CSuggestion:%mis a bit special. If one simply says%C%mfor picking up LT's replacement suggestions, then this will add the complete remainder of the multi-line message.