Skip to content

VimtexDocPackage: add support for environments#1928

Merged
lervag merged 1 commit intolervag:masterfrom
apfelkuchen6:master
Jan 24, 2021
Merged

VimtexDocPackage: add support for environments#1928
lervag merged 1 commit intolervag:masterfrom
apfelkuchen6:master

Conversation

@apfelkuchen6
Copy link
Copy Markdown

Previously calling VimtexDocPackage with the cursor over \begin{foo}
showed documentation related to \begin. Showing documentation
related to foo is probably always more useful.

As the environments are stored in the same completion file as the
commands (in the format ^\begin{foo}$), we can mostly wrap the code for
commands to get nice documentation for environments.

Previously calling VimtexDocPackage with the cursor over `\begin{foo}`
showed documentation related to \begin. Showing documentation
related to foo is probably always more useful.

As the environments are stored in the same completion file as the
commands (in the format ^\begin{foo}$), we can mostly wrap the code for
commands to get nice documentation for environments.
@lervag
Copy link
Copy Markdown
Owner

lervag commented Jan 24, 2021

Previously calling VimtexDocPackage with the cursor over \begin{foo}
showed documentation related to \begin. Showing documentation
related to foo is probably always more useful.

Agreed!

As the environments are stored in the same completion file as the
commands (in the format ^\begin{foo}$), we can mostly wrap the code for
commands to get nice documentation for environments.

Seems sensible. I'll review the code now.

@lervag lervag merged commit c7ffa7f into lervag:master Jan 24, 2021
@lervag
Copy link
Copy Markdown
Owner

lervag commented Jan 24, 2021

Thanks! I made some minor changes, but essentially your code was good and this definitely adds value to Vimtex. Appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants