VimtexDocPackage: add support for environments#1928
Merged
lervag merged 1 commit intolervag:masterfrom Jan 24, 2021
Merged
Conversation
Previously calling VimtexDocPackage with the cursor over `\begin{foo}`
showed documentation related to \begin. Showing documentation
related to foo is probably always more useful.
As the environments are stored in the same completion file as the
commands (in the format ^\begin{foo}$), we can mostly wrap the code for
commands to get nice documentation for environments.
Owner
Agreed!
Seems sensible. I'll review the code now. |
Owner
|
Thanks! I made some minor changes, but essentially your code was good and this definitely adds value to Vimtex. Appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously calling VimtexDocPackage with the cursor over
\begin{foo}showed documentation related to \begin. Showing documentation
related to foo is probably always more useful.
As the environments are stored in the same completion file as the
commands (in the format ^\begin{foo}$), we can mostly wrap the code for
commands to get nice documentation for environments.