fix: fzf toc display and jump error when spaces in file path#1996
Merged
lervag merged 1 commit intolervag:masterfrom Mar 21, 2021
Merged
fix: fzf toc display and jump error when spaces in file path#1996lervag merged 1 commit intolervag:masterfrom
lervag merged 1 commit intolervag:masterfrom
Conversation
Owner
Seems like a simple and useful hack. Thanks! Do you have or can you show a simple test case for this? |
Owner
|
That is: Can you show a simple/minimal example that currently fails that this PR will fix? |
Contributor
Author
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The file path and heading extracted by splitting at spaces would be wrong if the path contains spaces itself. Using \u2007 as a hack to preserve formatting (junegunn/fzf#585)