Fix(syntax): \lstset syntax highlighting

[144026]

Fixes #2000

Before fix

Note that the red } is somehow classified into a texGroupError:

After fix

[lervag]

Thanks! I assume #1999 was a duplicate as well? I'll look into this asap. I'll close #2000 and, if necessary, we'll discuss the related issue here. I hope that's OK by you.

[144026]

Thanks! I got something wrong in #1999 so I closed it, and opened this PR after I got things work.

[lervag]

Nice work, thanks! I had a very minor comment - I could probably just do that myself, but I also think it was worth suggesting it to allow a reply/additional comment.

[lervag]

Again, thanks! When I looked at it now, I realized: the reason I had the texLstsetGroup linked to texOpt was to make it look similar to the other option groups. I.e., to make the \lstset{...} argument look similar to the option group for \begin{lstlisting}[...]. I agree that it looks inconsistent. Perhaps a better idea is to rename that group, e.g. texLstsetOptarg or similar. I have to admit, naming things is difficult! A pragmatic choice is to leave this as it was (linked to texOpt), but renaming it (and keeping the link) may be better.

[lervag]

No need for duplicate texLstsetArg. :)

[lervag]

Yes, texLstsetArg might actually work very well. The reason I did not suggest it was because there is already a more specific texLstsetArg group; however, I don't think it is a problem. If the tests pass and things look good on your end, then I think we'll settle for this solution. If there should be any issues with it, we can solve them as they come.

[144026]

OK! Both github-ci and my local tests seem ok for now. I think the \lstset problem is almost settled.

But I would like point out why I did once choose to link to texGroup: (although it's out of the \lstset problem`)

The highlight for texCmd and texOpt are the same (under my base16 colorscheme), and it looks quite odd when I write multiple lines of texOpt & texCmd together:

In comparasion, the default Vim highlight is more reasonable:

[lervag]

OK! Both github-ci and my local tests seem ok for now. I think the \lstset problem is almost settled.

Great!

But I would like point out why I did once choose to link to texGroup: (although it's out of the \lstset problem`)

The highlight for texCmd and texOpt are the same (under my base16 colorscheme), and it looks quite odd when I write multiple lines of texOpt & texCmd together:

Ah, I see. They are not really the same, actually. See here:

vimtex/autoload/vimtex/syntax/core.vim

Lines 480 to 494 in 1ef97f0

	highlight def link texCmd Statement
	highlight def link texCmdSpaceCodeChar Special
	highlight def link texCmdTodo Todo
	highlight def link texCmdType Type
	highlight def link texComment Comment
	highlight def link texCommentTodo Todo
	highlight def link texDelim Delimiter
	highlight def link texEnvArgName PreCondit
	highlight def link texError Error
	highlight def link texLength Number
	highlight def link texMathDelim Type
	highlight def link texMathEnvArgName Delimiter
	highlight def link texMathOper Operator
	highlight def link texMathZone Special
	highlight def link texOpt Identifier

texCmd is by default linked to Statement, while texOpt is linked to Identifier. These groups should have different highlighting according to group-name. Thus, I would propose that this problem is really a problem with your colorscheme. You could either fix that "upstream", or you could apply some changes to your tex highlighting by customising the colors manually.

[lervag]

I think this was already good now, so I merged. Feel free to suggest further improvements/adjustments (either PR or issues).