Skip to content

Add a few commands for amstex#2119

Closed
tornaria wants to merge 7 commits intolervag:masterfrom
tornaria:amstex
Closed

Add a few commands for amstex#2119
tornaria wants to merge 7 commits intolervag:masterfrom
tornaria:amstex

Conversation

@tornaria
Copy link
Copy Markdown
Contributor

  • \DeclareMathOperator: since the body is in math mode, do not spell check
  • new commands: \theoremstyle, \numberwithin (2 args), \subjclas (1 opt + 1 arg): do not spell-check.

@lervag
Copy link
Copy Markdown
Owner

lervag commented Jul 27, 2021

Thanks! You even order the highlight groups consistently! :D

One minor thing, but important IMHO: Can you add some examples of the new commands to the test files, test-amsthm.tex and test-amsmath.tex? You might also want to add tests, but the most important thing is to make it easy to manually inspect with e.g. vim -u test-amsthm.vim.

@tornaria
Copy link
Copy Markdown
Contributor Author

I added examples with tests for all 5 commands in the PR and for \begin{proof}.

Rebased to master after the commit implementing #2086, everything seems to be working great together.

Thanks!

lervag added a commit that referenced this pull request Aug 27, 2021
@lervag
Copy link
Copy Markdown
Owner

lervag commented Aug 27, 2021

Thanks! Great work, much appreciated!

@lervag lervag closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants