use vimtex#util#trim() instead of trim() for Vim versions < 8.1#2121
Closed
Konfekt wants to merge 1 commit intolervag:masterfrom
Konfekt:trim
Closed
use vimtex#util#trim() instead of trim() for Vim versions < 8.1#2121Konfekt wants to merge 1 commit intolervag:masterfrom Konfekt:trim
Konfekt wants to merge 1 commit intolervag:masterfrom
Konfekt:trim
Conversation
The two occurrences of trim() in https://github.com/lervag/vimtex/blob/1782e479a0c6a716af3a92d5ed85b65ecfad3dc0/autoload/vimtex/parser/bib.vim#L34 and https://github.com/lervag/vimtex/blob/3807da1c530e46fb6a633a2268f6e435b16b657b/autoload/vimtex/fold/bib.vim#L24 are replaced by https://github.com/lervag/vimtex/blob/6228f72a8bcf25b31bf1a966de864349ed4ea61c/autoload/vimtex/util.vim#L192 for Vim versions < 8.1. This creates dependencies outside of the bib file, but they have been there before anyway.
Owner
|
Thanks! |
lervag
added a commit
that referenced
this pull request
Aug 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two occurrences of trim() in
vimtex/autoload/vimtex/parser/bib.vim
Line 34 in 1782e47
and
vimtex/autoload/vimtex/fold/bib.vim
Line 24 in 3807da1
are replaced by
vimtex/autoload/vimtex/util.vim
Line 192 in 6228f72
for Vim versions < 8.1.
This creates dependencies outside of the bib file, but they have been there before anyway.