biblatex syntax: support for concealment of additional biblatex commands

[krissen]

Adds support for concealment of additional biblatex commands.

(Additions to the test biblatex.tex file weren't require as the citation commands were already there. Previous to the changes suggested in this PR, several commands were not concealed. With it, all are.)

[lervag]

But do we want all of them concealed? Including \bibentry?

@whisperity and @Melkster I believe you were part of the original discussion on this topic. What do you think?

[krissen]

But do we want all of them concealed? Including \bibentry?

Indeed, bibentry was the one I was unsure about. The rest I do believe are all used in-text, and thus ought to be concealed. I'd think that would be the logic. "Should cites be concealed? Looks at variable for cite-concealment. Yes. Alright, all citation commands used in-text will be concealed."

However, if one would like to exclude some citation commands --- instead of adding a separate variable to test (i.e. vimtex_syntax_conceal_cites or some such with a list of types of citation commands to conceal), how about simply referring to vimtex_syntax_custom_cmds for un-concealment of individual commands? (conceal: 0).

[krissen]

Indeed, bibentry was the one I was unsure about.

Removed bibentry from cite-concealment.

[lervag]

Thanks! I've merged. Please note: I prefer if you don't merge master into your branch unless necessary. I like to keep a logically clean Git history, and it helps when I can easily rebase a branch on top of master before I merge.

I think you are right that this makes sense, and let's instead have the discussion if someone now should oppose this.

[krissen]

Please note: I prefer if you don't merge master into your branch unless necessary. I like to keep a logically clean Git history, and it helps when I can easily rebase a branch on top of master before I merge.

Got it. New to contributing through PR:s. Merged master in between, thinking it was proper practice, but see why it would've been better not to. Will keep it in mind should there be any future PR:s! 👍

[lervag]

I guess it is a matter of taste; I won't claim that my practise is correct or better, but it is my preferred workflow and I try to enforce it when I can :)