Improve highlight of commented code#2319
Merged
lervag merged 2 commits intolervag:masterfrom Feb 1, 2022
Merged
Conversation
The contents after \else should not be highlighted as a comment ref: lervag#1988
Highlight the \else section of \iftrue command as a comment ref: lervag#1988
lervag
added a commit
that referenced
this pull request
Feb 1, 2022
Owner
|
Thanks! I made a couple of minor adjustments myself, I hope you don't mind. I think you did a good implementation, but I want to keep it in my "style". And I used |
Contributor
Author
|
Thank you! I don't mind at all, in fact your adjustments helped me to better understand the way that VimL combines regions with each other. |
Owner
|
Great; glad to hear it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit is a simple fix for
\iffalse <commented-code>[\else <not-commented-code>]\ficommand.In the second commit i tried to add highlights for
\iftrue <not-commented-code> [\else <commented code>]\ficommand.I've never used vim syntax before, so i'm not sure if this is the correct way to implement \iftrue.
I must admit that this pr is not very useful. But it allows you, for example, a quick switch draft mode by simply replacing
\iftruewith\iffalseetc.