Skip to content

Add support for TeXShop viewer on macOS #2385

Closed
michaelliebling wants to merge 1 commit intolervag:masterfrom
michaelliebling:master
Closed

Add support for TeXShop viewer on macOS #2385
michaelliebling wants to merge 1 commit intolervag:masterfrom
michaelliebling:master

Conversation

@michaelliebling
Copy link
Copy Markdown
Contributor

@michaelliebling michaelliebling commented May 7, 2022

The changes extend VimTeX with the possibility to view pdf files in MacOS's TeXShop viewer, by providing a new let g:vimtex_view_method = 'texshop'.

Besides functions for forward search, VimTeX help and faq entries indicate how to set up TeXShop for backward search (with MacVim).

@michaelliebling
Copy link
Copy Markdown
Contributor Author

not ready for integration; wil come back when fully tested

Copy link
Copy Markdown
Owner

@lervag lervag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, thank you for the effort here! I will be happy to merge this when the various outstanding issues are resolved. The issues are mostly about style, although a couple of things in the main script is wrong, probably because you've built this quite a while ago with an earlier version of the view scripts. I made some major refactoring and improvements to the view scripts in december last year.

Let me know if something is unclear or if you need some help for anything here.

@michaelliebling
Copy link
Copy Markdown
Contributor Author

Many thanks for your patience and hints on how to fix the code and docs. I've now opened another Pull Request #2387 to replace this one.

@lervag
Copy link
Copy Markdown
Owner

lervag commented May 8, 2022

My pleasure; I'm always glad to see contributions like this. I'll review the new PR immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants