sioyek forward-search column number#2411
Closed
JingMatrix wants to merge 1 commit intolervag:masterfrom
JingMatrix:sioyek
Closed
sioyek forward-search column number#2411JingMatrix wants to merge 1 commit intolervag:masterfrom JingMatrix:sioyek
JingMatrix wants to merge 1 commit intolervag:masterfrom
JingMatrix:sioyek
Conversation
Contributor
Author
|
That request might be hard to merge, but a new request is more likely to be accepted: ahrm/sioyek#273, so I should reopen it. |
Owner
|
Thanks! I'll look into this when the sioyek PR has been merged; ok? |
Contributor
Author
|
The pull request is merged now, but for stability reason, current pull-request should wait for next release of |
Owner
|
Sounds good! |
lervag
added a commit
that referenced
this pull request
Nov 10, 2022
Owner
|
Thanks! I noticed that the latest release was in August, which means I should probably have merged this a long time ago. Better late then never, I guess :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, please don't merge it now; otherwise it will break.
It depends on my pull request ahrm/sioyek#271 , which is waiting for merging.