register the (arg)?mini[!*e]?, (arg)?maxi[!*]? environment from to region_math#2495
Merged
lervag merged 3 commits intolervag:masterfrom Sep 26, 2022
Merged
Conversation
lervag
reviewed
Sep 24, 2022
Owner
lervag
left a comment
There was a problem hiding this comment.
Thanks! This looks good and I don't see any immediate problems here. But I would kindly ask you to also add an example within test/test-syntax. Create two files, test-optidef.vim and test-optidef.tex. For this simple stuff you don't need to create any real tests, but having the example there makes it much easier for further development or bug fixing in the future in case something breaks.
Contributor
Author
|
I added some simple tests. |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package optidef provides mini, maxi, argmini, argmaxi environments that should be considered math environments.