Replace texlab url with github link#2548
Closed
krishnakumarg1984 wants to merge 1 commit intolervag:masterfrom
Closed
Replace texlab url with github link#2548krishnakumarg1984 wants to merge 1 commit intolervag:masterfrom
krishnakumarg1984 wants to merge 1 commit intolervag:masterfrom
Conversation
…e with github src
Contributor
|
Yes. That is intentional. |
Contributor
Author
|
Yup. So, maybe let's just provide people the github url directly in the documentation? |
Owner
|
I don't mind accepting this. @clason Is there a reason not to use the github url here? E.g., perhaps a more dedicated page is expected or planned and the current URL is a placeholder for that? |
Contributor
|
I don't care either way, but the "official" URL links to the github page by design, since there's no (need) for a separate webpage. |
lervag
added a commit
that referenced
this pull request
Oct 31, 2022
Owner
|
Thanks @krishnakumarg1984, I see no good reason not to accept the PR. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to navigate to the original texlab netlify URL in the browser, it redirects to the github page for the project.