Skip to content

Replace texlab url with github link#2548

Closed
krishnakumarg1984 wants to merge 1 commit intolervag:masterfrom
krishnakumarg1984:kg/update_texlab_url
Closed

Replace texlab url with github link#2548
krishnakumarg1984 wants to merge 1 commit intolervag:masterfrom
krishnakumarg1984:kg/update_texlab_url

Conversation

@krishnakumarg1984
Copy link
Copy Markdown
Contributor

When trying to navigate to the original texlab netlify URL in the browser, it redirects to the github page for the project.

@clason
Copy link
Copy Markdown
Contributor

clason commented Oct 30, 2022

Yes. That is intentional.

@krishnakumarg1984
Copy link
Copy Markdown
Contributor Author

Yup. So, maybe let's just provide people the github url directly in the documentation?

@lervag
Copy link
Copy Markdown
Owner

lervag commented Oct 30, 2022

I don't mind accepting this. @clason Is there a reason not to use the github url here? E.g., perhaps a more dedicated page is expected or planned and the current URL is a placeholder for that?

@clason
Copy link
Copy Markdown
Contributor

clason commented Oct 30, 2022

I don't care either way, but the "official" URL links to the github page by design, since there's no (need) for a separate webpage.

lervag added a commit that referenced this pull request Oct 31, 2022
@lervag
Copy link
Copy Markdown
Owner

lervag commented Oct 31, 2022

Thanks @krishnakumarg1984, I see no good reason not to accept the PR.

@lervag lervag closed this Oct 31, 2022
@krishnakumarg1984 krishnakumarg1984 deleted the kg/update_texlab_url branch November 4, 2022 10:40
@krishnakumarg1984
Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants