Skip to content

feat(syntax): add keywords to texCommentTodo#2839

Merged
lervag merged 1 commit intolervag:masterfrom
jiangyinzuo:master
Nov 28, 2023
Merged

feat(syntax): add keywords to texCommentTodo#2839
lervag merged 1 commit intolervag:masterfrom
jiangyinzuo:master

Conversation

@jiangyinzuo
Copy link
Copy Markdown
Contributor

I believe that the words 'ISSUE' and 'NOTE' are often highlighted in comments as well, and therefore, so I modified the syntax texCommentTodo.

@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 27, 2023

I believe that the words 'ISSUE' and 'NOTE' are often highlighted in comments as well, and therefore, so I modified the syntax texCommentTodo.

You may be right that these keywords are highlighted in some settings, but I'm not sure I agree they should be highlighted. Both of these words are quite common in regular text, and it can be confusing to have them highlighted in the comments. Notice that we are matching case insensitive; I would be more inclined to accept this if we only matched the upper case variants.

@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 27, 2023

I.e., instead of adding to the keywords list, we might instead add a new match rule just below with something like this:

  syntax match texCommentTodo "ISSUE\|NOTE"
        \ containedin=texComment contained

@jiangyinzuo
Copy link
Copy Markdown
Contributor Author

I agree with your point of view. I have changed the rule.

@lervag lervag merged commit 3913284 into lervag:master Nov 28, 2023
@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants