feat(syntax): add keywords to texCommentTodo#2839
Merged
lervag merged 1 commit intolervag:masterfrom Nov 28, 2023
Merged
Conversation
Owner
You may be right that these keywords are highlighted in some settings, but I'm not sure I agree they should be highlighted. Both of these words are quite common in regular text, and it can be confusing to have them highlighted in the comments. Notice that we are matching case insensitive; I would be more inclined to accept this if we only matched the upper case variants. |
Owner
|
I.e., instead of adding to the keywords list, we might instead add a new match rule just below with something like this: |
Contributor
Author
|
I agree with your point of view. I have changed the rule. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that the words 'ISSUE' and 'NOTE' are often highlighted in comments as well, and therefore, so I modified the syntax
texCommentTodo.