Skip to content

fix(vlty): use proper shellescape on windows #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lervag merged 1 commit into from
Jan 8, 2025
+12 −3
Merged

fix(vlty): use proper shellescape on windows #3070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions compiler/vlty.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,17 @@ if !executable(s:python)
call s:installation_error('requires Python')
finish
endif

if s:check_python('import sys; assert sys.version_info >= (3, 6)')
" shellescape after the executable check
" needed if s:python = g:python3_host_prog and contains spaces
let s:python = vimtex#util#shellescape(s:python)

if has('win32')
" escape > with ^ because cmd escape mechanism is weird
if s:check_python('import sys; assert sys.version_info ^>= (3, 6)')
call s:installation_error('requires at least Python version 3.6')
finish
endif
elseif s:check_python('import sys; assert sys.version_info >= (3, 6)')
call s:installation_error('requires at least Python version 3.6')
finish
endif
Expand Down Expand Up @@ -66,7 +75,7 @@ if s:vlty.server !=# 'lt'
finish
endif

let s:vlty_lt_command = 'java -jar ' . fnamemodify(s:jarfile, ':S')
let s:vlty_lt_command = 'java -jar ' . vimtex#util#shellescape(s:jarfile)
endif
endif

Expand Down