Skip to content

Simplify & improve bold+italic#8

Open
anjiro wants to merge 2 commits intolervag:masterfrom
anjiro:bolditalic
Open

Simplify & improve bold+italic#8
anjiro wants to merge 2 commits intolervag:masterfrom
anjiro:bolditalic

Conversation

@anjiro
Copy link
Copy Markdown
Contributor

@anjiro anjiro commented Nov 11, 2021

I realized my earlier PR #7 didn’t work for *bold with _embedded italic_ text* and _italics with *bold* text inside_. In the course of fixing that I simplified the code.

Works for *bold _italic_  more bold* etc
@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 11, 2021

I'm not sure this works as you think. At least, on my end, this no longer allows bold italics at all...

@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 11, 2021

That is, at the current master, *_...._* will give bold italics. With your PR, it will be only bold.

@anjiro
Copy link
Copy Markdown
Contributor Author

anjiro commented Nov 11, 2021

Hm, how strange… it worked briefly then stopped. I’ll investigate further.

@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 11, 2021

You added the contained to the syntax groups, but no other groups contain them. I believe it may be fixed by adding contains=... somewhere appropriate.

@anjiro
Copy link
Copy Markdown
Contributor Author

anjiro commented Nov 11, 2021

Yes, you’re right—I had to do some file shuffling to get the repository in the right place to do the PR and lost those lines. Try now?

lervag added a commit that referenced this pull request Nov 12, 2021
@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 12, 2021

Thanks, works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants