Fix file scheme handler to respect g:wiki_viewer

[lervag]

The file handler/follower function does not properly respect the g:wiki_viewer default key _:

wiki.vim/autoload/wiki/url/file.vim

Lines 37 to 41 in 871e55e

	if has_key(g:wiki_viewer, self.ext)
	call system(g:wiki_viewer[self.ext] . ' ' . shellescape(self.url) . '&')
	else
	execute 'edit' fnameescape(self.path)
	endif

The documentation for :help g:wiki_viewer implies that the _ key specifies a default viewer that is used if a specific viewer for a specific file type is not defined.

Suggested solution: Update s:handler.follow in url/file.vim to respect the g:wiki_viewer['_'] key.

[lervag]

I believe this should be resolved now. Please test.

[protist]

@lervag I've tested and can confirm it's working now. Thanks again for the super quick fix!

[protist]

Sorry @lervag. I tested a bit more, and it looks like I get some slightly inconsistent behaviour. For example, I tested a link to [foo](file:~/bar.md). This works perfectly if it opens within vim (i.e. goes through the conditional as per this thread then execute 'edit' self.path). However, if I change the conditional so that it passes by and uses g:wiki_viewer instead, I get an error from xdg-open saying that the file does not exist.

I'm not sure if it's a quoting issue, because if I change the path from ~/bar.md to /home/protist/bar.md, it works fine. Perhaps the ~ is not being expanded?

[lervag]

Sorry, try now.

[protist]

Thanks @lervag. Works perfectly now. Thank you again for the great work!

[lervag]

Great, glad to hear it! :)

[protist]

Sorry @lervag I found another bug (unless it's a feature?). Directories seem to open in the current instance of vim, whereas I would have expected them to open with xdg-open. I tested with and without the trailing slash:

• [foo](file:/path/to/dir): this opens in vim's directory viewer, similar to running vim /path/to/dir
• [foo](file:/path/to/dir/): this looks like it creates a new empty document, but the status line says "/path/to/dir" is a directory. Attempting to modify and save the file fails and gives E502: "/path/to/dir" is a directory

[lervag]

Sorry @lervag I found another bug (unless it's a feature?). Directories seem to open in the current instance of vim, whereas I would have expected them to open with xdg-open.

Strange; this works as expected for me in both of the examples, with and without the last slash. Could you open a new issue and provide the full details (i.e. your relevant config)?

[protist]

Oops, sorry @lervag, I got confused. I was running the stable version on one system, and the development version on another. The latest version works fine for directories. Sorry for the noise!

[lervag]

No problem :)