Journal: get_all_nodes and wiki: Current file is not a valid journal node!

[mizhozan]

First of all, thanks for this promising plugin! I tested vimwiki and got frustrated how it interfere with syntax/folding (markdown) and do not do those job well in the case of markdown at least (anti-posix?). Glad to find wiki.vim after file an issue in vimwiki!

I have a problem with custom g:wiki_journal{'date_format'}

let g:wiki_root = '~/Work/Notes'
let g:wiki_filetypes = ['md',  'wiki']
let g:wiki_link_extension = '.md'
let g:wiki_link_target_type = 'md'
let g:wiki_journal = {
          \ 'name': 'Jrn',
          \ 'frequency': 'daily',
          \ 'date_format': {
          \   'daily' : 'D%Y-%m%d',
          \   'weekly' : 'W%y-%V',
          \   'monthly' : 'M%y-%m',
          \ },
          \}

I did this:

1. <leader>w<leader>w works as expected and create a journal file of the day as expected.

2. Run :WikiJournalNext and it gave this error:

   Error detected while processing function wiki#journal#go[5]..wiki#journal#get_all_nodes:
   line 1:
   E716: Key not present in Dictionary: ""
   E116: Invalid arguments for function wiki#date#format_to_regex(g:wiki_journal.date_format[a:frq])
   

3. Run :WikiJournalToWeek

   wiki: Current file is not a valid journal node!
     /run/media/mizho/DTA/Notes/Jrn/D2023-0226.md
   

However, when I removed the daily format it seems working. I guess it's bcz of node_to_timestamp in the function! wiki#journal#go_to_frq(frq) don't parse pattern like D2023-0226 bcz of that D, though not sure.

p.s. updated the issue and separate it from #273 .

[lervag]

First of all, thanks for this promising plugin!

I'm glad you find it promising! If I'm able, I will be glad to help you find ways to make it work well for you.

I have some problem with the journal part. I mainly use journals for task/time management and small comments.

In case you are interested, I just added a short prose about how I do my journalling to the docs. See #270 for related issue thread. If you update wiki.vim then do :help wiki-intro-guide you will find my full (personal and subjective!) guide.

Here are my main issues:

First, is it possible to have separate directory?

No, not currently. Thus, that is a feature request, but I'm willing to discuss it and possibly implement it.

I have maintained a Journal directory for years now and think separate Journal dir is a better solution.

I've maintained my wiki and journal for 10 years now, and this has never bothered me. Still, I want wiki.vim to work well for most people regardless of their workflow. I can see why you want a separate directory, and I don't have a good counter argument for why it should not be supported.

Do you mind opening a second issue for this as a feature request? I.e. a request for wiki.vim to support using separate directories for the journal. We will need to discuss how that should work; e.g. how to write links between the journal and the wiki.

Second, I've tried config wiki.vim as follows …

This looks like a bug. Thanks for writing such a detailed report with the steps to reproduce. I don't have more time now, but I will try to reproduce it and fix it!

Here Work/ is a symlink to another location on file system if that matters. I need this cause I have multiple machines with same dot files and basically manage different path with symlinks

I don't think that should matter.

3. Run :WikiJournalToWeek

   wiki: Current file is not a valid journal node!
     /run/media/mizho/DTA/Notes/Jrn/D2023-0226.md
   

This is a separate issue; I'll look into the first one first. Feel free to remind me about this one if I should forget it!

I guess it's bcz of node_to_timestamp in the function! wiki#journal#go_to_frq(frq) don't parse pattern like D2023-0226 bcz of that D, though not sure.

I think you are on to something here, but I actually expected things like this to work. I hope to get the time to look at it in the next couple of days!

[mizhozan]

Thanks for the detail reply.

In case you are interested, I just added a short prose about how I do my journalling to the docs. See #270 for related issue thread. If you update wiki.vim then do :help wiki-intro-guide you will find my full (personal and subjective!) guide.

That was pretty interesting read I appreciate :h :help wiki-intro-guide added to the doc. I am almost agree on all points and to high degree follow the same. The main difference is during the years I've created some sort of python scripts here and there for task management, timing, pulling tasks, etc for journals and unlike regular notes, it's hierarchical.

Do you mind opening a second issue for this as a feature request?

I did so in #273

I don't think that should matter.

Correct, symlinks are irrelevant here.

I think you are on to something here, but I actually expected things like this to work.

I did test this possible bug, and this time I only remove the prefix D from daily format i.e. from 'daily' : 'D%Y-%m%d' to 'daily' : '%Y-%m%d' and it work as expected. Interestingly it only affects the daily option. For weekly and monthly there is no problem with the W and M prefix.

[lervag]

I've tried to reproduce this, but on my end, it seems to work as expected. I have these files:

lervag@lotti: test/issues/272 on  master
❯ tree
.
├── index.md
├── journal
│   ├── D2023-0302.md
│   └── D2023-0303.md
└── test.vim

where the .md files contain stuff like "foo bar" and lorem ipsum, whereas test.vim has this:

set nocompatible
set runtimepath^=~/.local/plugged/wiki.vim
filetype plugin indent on
syntax enable

let g:wiki_root = '.'
let g:wiki_filetypes = ['md']
let g:wiki_link_extension = '.md'
let g:wiki_link_target_type = 'md'
let g:wiki_journal = {
      \ 'date_format': {
      \   'daily' : 'D%Y-%m%d',
      \   'weekly' : 'W%y-%V',
      \   'monthly' : 'M%y-%m',
      \ },
      \}

nnoremap q :qall!<cr>

runtime plugin/wiki.vim

WikiJournal
WikiJournalNext

I run nvim --clean -u test.vim. No errors, everything seems to work as expected. Could you attempt to reproduce your problem with a minimal example such as the one I've provided here? Notice that runtimepath must point to the location of wiki.vim on your computer.

[lervag]

Another way to debug: add this

echom "DEBUG" l:node l:frq

below line 29 here:

wiki.vim/autoload/wiki/journal.vim

Lines 29 to 30 in c314380

	let l:frq = wiki#journal#get_node_frq(l:node)
	let l:nodes = wiki#journal#get_all_nodes(l:frq, [l:node])

After you get the error, type :messages to see the message log, you should be able to see the values of the variables. They may help explain the problem.

[lervag]

Also, for completeness, it would help to know some more details of your system. Linux, MacOS, Windows; distribution, Vim version.

[mizhozan]

Yes, with this clean environment I also didn't have a problem. Upon further test, It seems the problem comes from set ignorecase in my vim config. I actually had a set smartcase just after it but still it seems incompatible setting. So the minimal example would be this:

set nocompatible
set runtimepath^=~/.local/plugged/wiki.vim
filetype plugin indent on
syntax enable
set ignorecase

let g:wiki_root = '.'
let g:wiki_filetypes = ['md']
let g:wiki_link_extension = '.md'
let g:wiki_link_target_type = 'md'
let g:wiki_journal = {
      \ 'date_format': {
      \   'daily' : 'D%Y-%m%d',
      \   'weekly' : 'W%y-%V',
      \   'monthly' : 'M%y-%m',
      \ },
      \}

nnoremap q :qall!<cr>

runtime plugin/wiki.vim

WikiJournal
WikiJournalNext
WikiJournalToWeek

on the same tree as yours and vim --clean -u test.vim gives this error for me:

"~/Desktop/debug_wikivim/journal/D2023-0304.md" 1L, 3B
DEBUG D2023-0304
Error detected while processing /home/alset/Desktop/debug_wikivim/test.vim[24]..function wiki#journal#go[6]..wiki#journal#get_all_nodes:
line    1:
E716: Key not present in Dictionary: ""
E116: Invalid arguments for function wiki#date#format_to_regex(g:wiki_journal.date_format[a:frq])
wiki: Current file is not a valid journal node!
  /home/alset/Desktop/debug_wikivim/journal/D2023-0304.md

note the debug is in place and seems OK (as far as I understand).

I already removed that problematic ignorecase setting and it resolved.

---

OS: Archlinux (6.2.1)
Vim: 9.0.1337-1

[lervag]

Yes, with this clean environment I also didn't have a problem. Upon further test, It seems the problem comes from set ignorecase in my vim config. I actually had a set smartcase just after it but still it seems incompatible setting.

Ah, I see. These settings have an impact on things like call substitute() and similar. I've not been careful enough here, so I've not added explicit case insensitive regexes. I fixed the current issue by adding a couple of \c to two regexes.

note the debug is in place and seems OK (as far as I understand).

Actually, no; the l:frq was empty and should not be empty. When I could reproduce I could also quickly fix this one. Thanks!

I already removed that problematic ignorecase setting and it resolved.

I believe users should avoid ignorecase. smartcase makes more sense, but similar to the magic option, these option will have a chance of breaking plugins. This is because plugin authors like myself can easily forget that behaviour of regexes depend on user settings like these. For plugin authors, it is actually a good practise to be explicit about case and magicness, e.g. by using regexes like \C\v... or similar. But it is easy to forget this!