Support for Asciidoctor style of links#110
Closed
mgoral wants to merge 5 commits intolervag:masterfrom
Closed
Conversation
Format: <<file.adoc#,title>>. They're specific to asciidoctor.
This excludes anchors.
This fixes toggling and creating adoc links with wiki_map_link_create
Contributor
Author
|
I think this is now more-less complete. @lervag, can you have a look? |
lervag
added a commit
that referenced
this pull request
Nov 7, 2020
Owner
|
Thanks! This was IMHO a very high quality PR, I just made some simple adjustments of the docs and merged it immediately. I did not test very thoroughly, and I think the only thing that could be said to be missing was one or two simple tests. I'll add that if I find it necessary myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements Asciidoctor Inter-Page Cross References style links:
Implemented things:
get_anchorsfunction and creating a single regex for Asciidoc, next tog:wiki#rx#header_itemsfeels hacky)Fixes #109