Skip to content

Support for Asciidoctor style of links#110

Closed
mgoral wants to merge 5 commits intolervag:masterfrom
mgoral:master
Closed

Support for Asciidoctor style of links#110
mgoral wants to merge 5 commits intolervag:masterfrom
mgoral:master

Conversation

@mgoral
Copy link
Copy Markdown
Contributor

@mgoral mgoral commented Oct 28, 2020

This implements Asciidoctor Inter-Page Cross References style links:

<<file.adoc#,title>>

Implemented things:

  • ordinary links things (creating, following, regular expresssions for parsing etc.)
  • links toggling (wiki -> md -> adoc -> wiki)
  • omni function (without anchors; regular expression for finding anchors is hardcoded in get_anchors function and creating a single regex for Asciidoc, next to g:wiki#rx#header_items feels hacky)

Fixes #109

Format: <<file.adoc#,title>>. They're specific to asciidoctor.
This fixes toggling and creating adoc links with wiki_map_link_create
@mgoral
Copy link
Copy Markdown
Contributor Author

mgoral commented Nov 6, 2020

I think this is now more-less complete. @lervag, can you have a look?

lervag added a commit that referenced this pull request Nov 7, 2020
@lervag
Copy link
Copy Markdown
Owner

lervag commented Nov 7, 2020

Thanks! This was IMHO a very high quality PR, I just made some simple adjustments of the docs and merged it immediately. I did not test very thoroughly, and I think the only thing that could be said to be missing was one or two simple tests. I'll add that if I find it necessary myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Asciidoc style of links

2 participants