fix: avoid toggling empty links, fix bug where some functions don't get called in template#192
Merged
lervag merged 2 commits intolervag:masterfrom Oct 3, 2021
Merged
Conversation
Owner
Thanks, glad you like it!
I'm quite impressed that you managed to fix the errors; well done! Especially the second one is quite intricate, and I would not be surprised if I would have spent some time pinpointing and fixing it myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Hi @lervag, I really like your plugin so far! I made a few small changes locally and thought I'd share them:
Changes
wiki#link#follow(don't attempt to toggle an empty link)l:lineschanges, andl:c2can extend beyond the beginning of the next curly-braces defining another custom function.