Make it possible to customize local journal mappings#216
Merged
lervag merged 3 commits intolervag:masterfrom Jan 28, 2022
Merged
Make it possible to customize local journal mappings#216lervag merged 3 commits intolervag:masterfrom
lervag merged 3 commits intolervag:masterfrom
Conversation
lervag
requested changes
Jan 28, 2022
Owner
lervag
left a comment
There was a problem hiding this comment.
Thanks! This looks like a useful addition. I have two minor comments.
autoload/wiki/buffer.vim
Outdated
|
|
||
| call extend(l:mappings, get(g:, 'wiki_mappings_local', {})) | ||
| if b:wiki.in_journal | ||
| call extend(l:mappings, get(g:, 'wiki_mappings_journal_local', {})) |
Owner
There was a problem hiding this comment.
Could I suggest local_journal instead of journal_local?
|
|
||
| For any local mappings that should only be applied in journal entries, | ||
| consider setting |g:wiki_mappings_journal_local|. | ||
|
|
Owner
There was a problem hiding this comment.
Perhaps one should add an example for this as well?
Contributor
Author
There was a problem hiding this comment.
Added an example and an extra table for the defaults.
Owner
|
Thanks! I hope you don't mind that I made a minor adjustment on top of this. In any case, I appreciate your contribution! |
Contributor
Author
Thanks! no worries. My main goal was to get the setting in, so I am happy that you could review this this quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small addition of an extra setting and a short intro in the docs.