Adding support for neovim vim.ui.select

[saccarosium]

related to: #274

• Removing WikiFzf{Pages,Tags,Toc} in favor of Wiki{Pages,Tags,Toc}

This uses on Neovim vim.ui.select and on vim junegunn/fzf.

• Renaming WikiPageToc and WikiPageLocToc to WikiGenerateToc and WikiGenerateLocToc

This is for prefenting user confusion with WikiToc and also make more clear the outcome of the command.

Demos

with FzfLua

WikiPages

WikiTags

WikiToc

with Telescope

WikiPages

WikiTags

WikiToc

[lervag]

Removing WikiFzf{Pages,Tags,Toc} in favor of Wiki{Pages,Tags,Toc}

This uses on Neovim vim.ui.select and on vim junegunn/fzf.

Thank you, I really appreciate your work here! I was already working on this myself, but it was not going very fast. I'm glad to have help here!

Renaming WikiPageToc and WikiPageLocToc to WikiGenerateToc and WikiGenerateLocToc

Thanks, I agree on this suggestion, except that I want it to be WikiTocGenerate... and similar for the mappings.

---

I believe we are quite close already with your effort, but we need some more work:

• Now we are "breaking" things for those who are using neovim who wants to use fzf. I believe we could solve this with a new option, e.g. g:wiki_select_method. The default value would be fzf for Vim and nvim for neovim, and it would allow neovim users to revert to the old fzf backend.

• We need updated docs for the Wiki{Pages,Tags,Toc} commands that distinguish the command intents from the "implementation" (neovim vs fzf).

• Is it possible to somehow add a previewer with vim.ui.select?

• Is it possible and relevant to add a formatter for wiki.pages()?

• Is it possible and relevant to add a formatter for wiki.toc()?

[lervag]

I don't mind this change, except I would prefer WikiTocGenerate. But we also need to make this change later (near line 111).

[lervag]

Sorry, but I was probably unclear on my last sentence. You changed WikiPageToc to WikiTocGenerate now, but you did not change the map definition later on line 115:

  nnoremap <silent><buffer> <plug>(wiki-page-toc)             :WikiPageToc<cr>

[lervag]

Here we need some updated docs.

[saccarosium]

Is it possible to somehow add a previewer with vim.ui.select?

I don't think is possible natively, or in a way that it is general enogh for all kinds of fuzzy finders.

We need updated docs for the Wiki{Pages,Tags,Toc} commands that distinguish the command intents from the "implementation" (neovim vs fzf).

My plan was to write it myself but I need help on where is appropriate to make (under what heading/subsection)

[lervag]

There's a minor detail left (line 115 of buffer.vim), and the docs. I can do the docs.

Also, I appreciate that you've used conventional commits here!

[lervag]

I've merged this now and also pushed an update to the docs. Let me know what you think.

[saccarosium]

I think is a good idea listing this integration in the README. As you saw in some of the GIFs if uploaded the user can use basecly every neovim fuzzy finder, is very cool!

[lervag]

I've tried to list these now.