Skip to content

fix: WikiTagRename failure after so many tags #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lervag merged 3 commits into from
Mar 31, 2023
Merged

fix: WikiTagRename failure after so many tags #285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24fcd43
fix: WikiTagRename failure after so many tags
trev-dev Mar 29, 2023
1d81add
fix: method syntax breaks current compatibility
trev-dev Mar 30, 2023
4b71bd2
fix: simplify wiki tag rename loop
trev-dev Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions autoload/wiki/tags.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,6 @@ function! s:tags.rename(old_tag, new_tag, ...) abort dict " {{{1

call wiki#log#info('Renaming tag "' . a:old_tag . '" to "' . a:new_tag . '".')

let l:tagpages = self.collection[a:old_tag]

let l:bufnr = bufnr('')
" Get list of open wiki buffers
let l:bufs =
Expand All @@ -425,12 +423,12 @@ function! s:tags.rename(old_tag, new_tag, ...) abort dict " {{{1
endfor

let l:num_files = 0
let l:tagpages = remove(self.collection, a:old_tag)

" We already know where the tag is in the file, thanks to the cache
for [l:file, l:lnum] in l:tagpages
if s:update_tag_in_wiki(l:file, l:lnum, a:old_tag, a:new_tag)
call self.add(a:new_tag, l:file, l:lnum)
call remove(self.collection, a:old_tag)
let l:num_files += 1
endif
endfor
Expand Down