Large refactoring of URL handlers and resolvers#304
Merged
Conversation
a2d6966 to
3fe7aba
Compare
This was referenced May 13, 2023
1bc6dd9 to
c67387b
Compare
This changes the implementation of how URLs are resolved and handled. The old style was somewhat convoluted in that the URLs were unnecessarily entwined with the link concept. The new implementation more properly separates the concepts. This is a major step towards allowing more flexibility for users to define their own URL resolvers and handlers. In the process, the g:wiki_resolver option was removed. This will temporarily _remove_ some flexibility. However, the idea is that the new ideas should allow much more flexibility. refer: #302
The new g:wiki_link_schemes now covers this in a much more general manner. refer: #302
Also, wiki.vim is no longer considered "simple". It should be simple and easy to use, and it should preferably be easy to read the code and understand it.
35105db to
b29cc1b
Compare
Owner
Author
|
The PR now delivers beyond its promise and includes a very big update of the docs as well. I will merge this within a couple of days unless I get feedback that advices not to merge. |
Contributor
|
I think this is a really good feature. I've tested briefly an I think is all good. |
Owner
Author
|
Thanks! As there was a bug on the master branch I decided to juts merge this now. I'm using it for my daily work and it seems to work as expected. Of course, if you should see any big problems, please let me know! |
saccarosium
approved these changes
May 15, 2023
Contributor
saccarosium
left a comment
There was a problem hiding this comment.
Reviewed the code, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #302 for the design discussion.
This is ready for review and test by anyone willing and able.