Improve fzf select#376
Merged
lervag merged 3 commits intolervag:masterfrom Aug 20, 2024
A-dot-S-dot:improve-fzf-select
Merged
Conversation
added 3 commits
August 19, 2024 16:09
I removed `g:wiki_fzf_pages_force_create_key` and replaced it by `g:wiki_fzf_force_create_key` that is used as well as for `wiki#fzf#pages` as for `wiki#fzf#links`.
Owner
Ok; this is for the displayed field that you are searching in, right? The reason it was there is to make it clear that the page is "rooted". But I'm not sure if that's really necessary.
Ok, thanks!
Sounds useful, thanks! I'll look at the code now and will probably merge this immediately. |
lervag
added a commit
that referenced
this pull request
Aug 20, 2024
This brings a minor breaking change: The option g:wiki_fzf_pages_force_create_key is renamed to g:wiki_fzf_force_create_key, since it is now also used for wiki#fzf#links. refer: #376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @lervag,
I suggest three improvements for
wiki#fzf#linkwhich also fixes a bug. I combined them in one pull request, because they depend on each other./in the beginning of every search query inwiki#fzf#pagesandwiki#fzf#links.wiki#fzf#linkdoes not work for new links, since themodevariable is incapsulated in existing pages. The second commit fixes this issue.wiki#fzf#linksimilar to the one ofwiki#fzf#pages. It is worth mentioning that I changedg:wiki_fzf_pages_force_create_keytog:wiki_fzf_force_create_keyto make it usable for both mentioned selecting methods.Best regards