fix: pass function name when defining mappings#388
Merged
lervag merged 1 commit intolervag:masterfrom Nov 3, 2024
rvmtz:master
Merged
fix: pass function name when defining mappings#388lervag merged 1 commit intolervag:masterfrom rvmtz:master
lervag merged 1 commit intolervag:masterfrom
rvmtz:master
Conversation
Ensures `g:wiki_select_method` is evaluated during mapping definition, allowing `bang_wrapper()` to receive the function name instead of a variable name.
Contributor
Author
|
@lervag , thanks for sharing your plugin. I use it on a daily basis. 😅 |
Owner
Thanks, very happy to hear that!
And sorry about that; I forgot to test these. Thanks for noticing the error and pushing a fix for it! Very well done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures
g:wiki_select_methodis evaluated during mapping definition,allowing
bang_wrapper()to receive the function name instead of a variable name.