Minor tweaks and cleanup #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump engines to node.js 0.10 which is what clean-css is using.
|
I added you as a collaborater.. if you give me your npm username I can give you publishing permissions. |
|
Hey. I use the same username on npm just lowercase (xhmikosr).
How do you want to proceed with the clean-css upgrade? I think I will merge
this and release a patch version and then look into the new clean-css.
…On Feb 19, 2017 18:31, "Luke Page" ***@***.***> wrote:
I added you as a collaborater.. if you give me your npm username I can
give you publishing permissions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtUfGHT-HGNmpyykynPGXgH2RJIg8ks5reG5GgaJpZM4MFZx7>
.
|
|
Sounds good. I'm no longer involved much with less.js and have precious little time for o/s at the moment. |
|
I understand. No worries I'll make a few changes now that I have time for
open source.
…On Feb 19, 2017 22:16, "Luke Page" ***@***.***> wrote:
Sounds good. I'm no longer involved much with less.js and have precious
little time for o/s at the moment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtQKP4rPeAz6UAbVJZcelZ5Onatejks5reKMfgaJpZM4MFZx7>
.
|
|
When you give me npm rights I'll publish a patch version and then look into the clean-css update. I'd still like your opinion about dropping advanced and just use clean-css default which is O1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukeapage: after this I could have a look at bumping clean-css and making the adaptation.
Also, this closes #17 since it includes a similar change.