options version 3x

[bassjobsen]

As far as i understand the option should be changed according https://github.com/jakubpawlowicz/clean-css#how-to-upgrade-clean-css-from-2x-to-3x

Both advanced and rebase are set to false by default now.

[seven-phases-max]

Btw. can't we just remove these conditions at all? Obviously undefined is already false by default.

[bassjobsen]

Well clean css sets advanced and rebase to true by default, so we have to set it explicit to false on undefined. And yes indeed the --skip..... option do make any sense now and can be replace by the advanced and rebase options

[seven-phases-max]

Well clean css sets advanced and rebase to true by default,

Ah, indeed - my bad (what a mess! :). OK, then can we simply put plugin's default values there, e.g. just:

options = {
   advanced: false,
   rebase:   false
};

Probably it's already getting a bit prose but would not it be more straight-forward to keep all this in one place? (I.e. why to bother fiddling with options in clean-css-processor.js itself?)

`

[seven-phases-max]

OK, then can we simply put plugin's default values [there]

Ah, never mind I can see it won't be correct (since plugin can be created w/o options passed in). OK, then it's OK as you wrote it

(Probably I need to experiment with creating similar plugins myself to see if such things can be simplified - having 4 files and 3 points of options modification seems to be quite an overkill for a plugin that simply copies a few values from one place to another :).

[lukeapage]

The plugin parses the command line options to cleancss, which when i
checked are unchanged.. so although programmatically noAdvanced changed to
advanced, the command line still defsults to true doesnt it? And thats what
we are emulating?

[lukeapage]

Yes just checked and the command line is unchanged from v2 to v3.

So when the plugin parses a string, we are calling from lessc and should
emulate clean css command line options. When plugin is programmatic e.g. in
grunt, you pass an object that is unchanged and matches the programmatic
interface.

[bassjobsen]

Well i see now. Excuse me for the misunderstanding.

[lukeapage]

No worries.

[bassjobsen]

But........ with foo.less:

.foo {
  background-size: 200px; //for old browsers
  background-size: cover;
}

Both lessc foo.less --clean-css and lessc foo.less --clean-css="advanced=true" give me:

.foo{background-size:cover}

Where i expect that lessc foo.less --clean-css outputs:

.foo{background-size:200px;background-size:cover}

[lukeapage]

I think i may have intended to change to the same defaults as clean css but
not updated the documentation. Im open to opinion/prs to fix documentation
or change code to default advanced to false again.

[lukeapage]

Okay, now i see your changes and the code (im just on a mobile) i see your changes are all good apart from the changes to parse options - unless clean css dont call it skip rebase on the command line.

[bassjobsen]

I think clean css calls it skip rebase, but you set rebase to false by default. Which makes that you should set skip-rebase makes no sense. But how to call the option to turn rebasing on?

[lukeapage]

Ha, yes. Id say we need both options for compatability.

[bassjobsen]

My PR has both options (turned to false by default). To turn them on you should set advanced and /pr rebase.

[lukeapage]

I meant rebased and skip-rebase..