Skip to content

demo: show how to avoid <cleartext HTTP traffic not permitted> an… - #1186

Merged
Jacksgong merged 4 commits into
lingochamp:masterfrom
rantianhua:refactor/service
Feb 18, 2019
Merged

demo: show how to avoid <cleartext HTTP traffic not permitted> an…#1186
Jacksgong merged 4 commits into
lingochamp:masterfrom
rantianhua:refactor/service

Conversation

@rantianhua

@rantianhua rantianhua commented Feb 3, 2019

Copy link
Copy Markdown
Collaborator

…d lack of FOREGROUND_SERVICE permission in demo

more detail please refer to https://stackoverflow.com/questions/45940861/android-8-cleartext-http-traffic-not-permitted

Closes #1171

@Jacksgong

Copy link
Copy Markdown
Collaborator

I can't get point about cleartext HTTP traffic not permitted. could you please more detail about that refer to the commit you provide, and if it will affect the real case if people use FileDownloader, please add it to the readme doc.

p.s. change the MR title from refactor to demo.

@rantianhua rantianhua changed the title refactor: show how to avoid <cleartext HTTP traffic not permitted> an… demo: show how to avoid <cleartext HTTP traffic not permitted> an… Feb 5, 2019
@Jacksgong

Copy link
Copy Markdown
Collaborator

Okay, what about other URLs declared on the Contacts?

@rantianhua

rantianhua commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator Author

I have handled all domains in Constant.

@Jacksgong

Copy link
Copy Markdown
Collaborator

赞。

@Jacksgong
Jacksgong merged commit 34299a6 into lingochamp:master Feb 18, 2019
Comment thread README.md

Just create your own `DownloadMgrInitialParams.InitCustomMaker` and put those customized component to it, finally init the FileDownloader with it: [FileDownloader#init](https://github.com/lingochamp/FileDownloader/blob/master/library/src/main/java/com/liulishuo/filedownloader/FileDownloader.java#L62)

## Adaptation

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rantianhua 中文的readme中要不也加下?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有的,你应该看到了吧?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants